Prevent collapsing batch dims in dot ops with constants #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2823 +/- ##
========================================
Coverage 91.92% 91.93%
========================================
Files 489 489
Lines 19275 19301 +26
========================================
+ Hits 17719 17744 +25
- Misses 1556 1557 +1 ☔ View full report in Codecov by Sentry. |
|
SDXL Pref results for reference: Torch-MIGraphX (end to end): ONNX Unet (4x attn trim): As expected, it doesnt affect the onnx version much because there is an extra convert in the middle. Once the convert is handled, the perf number reduces to 5.47ms. |
pfultz2
reviewed
Feb 23, 2024
src/simplify_reshapes.cpp
Outdated
|
|
||
| auto sq_const = | ||
| m.insert_instruction(mbr, make_op("squeeze", {{"axes", sq_axes}}), constant); | ||
| m.replace_instruction(mbr, mbr->get_operator(), sq_const); |
There was a problem hiding this comment.
Couldn't we replace it with broadcast instead?
There was a problem hiding this comment.
This is just removing any unnecessary preceding dims in literals eg. {1, 1, 640, 640) which are later broadcasted to something like {2, 32, 640, 640}. Would broadcast work for this? I thought it only does 1 axis
pfultz2
reviewed
Feb 23, 2024
umangyadav
reviewed
Feb 23, 2024
umangyadav
reviewed
Feb 23, 2024
umangyadav
reviewed
Feb 26, 2024
umangyadav
approved these changes
Feb 26, 2024
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
pfultz2
reviewed
Mar 7, 2024
pfultz2
reviewed
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies many
reshape -> dot -> reshapepatterns that are not handled by thefind_reshape_reshape_dotpass (ie. in gemms where one input is a constant).This also simplifies the reshape found in #2736